Tests: Ensure no timers are running at the end of each test #1920
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arschmitz
approved these changes
May 15, 2020
dmethvin
approved these changes
May 15, 2020
This helps fix issues that make tooltip tests sometimes fail when run against jQuery 3.2 or newer due to timing differences. This commit adds a function to be attached at `afterEach` & attaches it to `common.testWidget`.
This helps fix issues that make tooltip tests sometimes fail when run against jQuery 3.2 or newer due to timing differences. This commit attaches the `moduleAfterEach` function with timer checks to most test suites.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps fix issues that make tooltip tests sometimes fail when run against
jQuery 3.2 or newer due to timing differences.
Reviewing by commit might be easier; the third commit is the biggest one but it just adds proper
afterEachcallbacks to all the test modules; most of the actual logic is in the other, much smaller commits.