Skip to content

Core: use correct module format for r.js optimization #1830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

blacktail
Copy link

@blacktail blacktail commented Aug 28, 2017

if there is no real function definition in the AMD define, r.js won't generate an entry for the core.js in the generated bundle, which will make errors if some project use r.js to bundle.

@jsf-clabot
Copy link

jsf-clabot commented Aug 28, 2017

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

@blacktail blacktail force-pushed the master branch 4 times, most recently from 780a057 to 26414d5 Compare August 28, 2017 09:53
Base automatically changed from master to main February 19, 2021 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants