Skip to content

[1.13] Dialog: Add icons option to support titlebar icons #1791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[1.13] Dialog: Add icons option to support titlebar icons #1791

wants to merge 3 commits into from

Conversation

scottgonzalez
Copy link
Member

Still needs tests, but I wanted to make sure the team is good with adding this option.

See ticket 15121.

@jsf-clabot
Copy link

jsf-clabot commented Jan 25, 2017 •
edited
Loading

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

@jzaefferer
Copy link
Member

Seems good!

@scottgonzalez
Copy link
Member Author

Added tests.

@scottgonzalez
Copy link
Member Author

Note that I also changed the implementation because the original implementation didn't handle updating the icon after init.

@scottgonzalez scottgonzalez changed the title [WIP] Dialog: Add icons option to support titlebar icons Dialog: Add icons option to support titlebar icons Feb 1, 2017
@scottgonzalez scottgonzalez changed the title Dialog: Add icons option to support titlebar icons [1.13] Dialog: Add icons option to support titlebar icons Feb 1, 2017
@scottgonzalez
Copy link
Member Author

scottgonzalez commented Feb 1, 2017 •
edited
Loading

This PR now also removes the back compat for dialogClass. The deprecated tests were failing because I hadn't updated the options in common-deprecated.js. Since this can't land in 1.12 anyway, I figured I might as well just remove the back compat now.

jzaefferer
jzaefferer approved these changes Feb 6, 2017
View reviewed changes
Copy link
Member

@jzaefferer jzaefferer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Could add a title icon to one of the demos, or at least to some of the visual tests for dialog.

Either way, this will wait for 1.12.2, right?

@scottgonzalez
Copy link
Member Author

Yeah, this can't be released until 1.13.

Base automatically changed from master to main February 19, 2021 19:58
@nagyimre1980
Copy link

nagyimre1980 commented Oct 10, 2022 •
edited
Loading

For me this would be an important function. Could 1.13.3 be released? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzaefferer jzaefferer jzaefferer approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Comp: Dialog Feature
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@scottgonzalez @jsf-clabot @jzaefferer @nagyimre1980 @fnagel