Droppable: Fix bubbling of greedy droppables #1770
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove code that made the false assumption that if dragging an element out of the greedy child, it is always over the parent. This is not always true, as the child could be right on the parents border, or even pushed (partially) outside of the parent. - This commit includes the fixes of maimairel, the original author of #9389 from his fiddle http://jsfiddle.net/fvjF4/ Fixes: #9389
|
|
This was referenced Nov 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove code that made the false assumption that if dragging an element
out of the greedy child, it is always over the parent. This is not
always true, as the child could be right on the parents border, or
even pushed (partially) outside of the parent.
This commit includes the fixes of maimairel, the original author of
#9389 from his fiddle http://jsfiddle.net/fvjF4/
This fiddle demonstrates the fix: https://jsfiddle.net/dritter/36gvy1a7/
Just move the blue box over the green boxes. You'll see no yellow flash of the parent box (red).
Fixes: #9389