Controlgroup: Add "only" position to class generator functions #1711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <option>Slow</option> | ||
| </select> | ||
| </div> | ||
| <div class="controlgroup-single-simple"> |
There was a problem hiding this comment.
Let's rename this to controlgroup-single-button to match the one above (also update the test titles).
|
Other than the one naming change, this looks good. |
| var options = that[ "_" + instance.widgetName + "Options" ]( | ||
| children.length === 1 ? | ||
| "only" : | ||
| value |
There was a problem hiding this comment.
These two lines should be indented, but I'd probably put the entire ternary on a single line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14972