Only run triggerHandler( "remove" ) for widgets #1182
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ui.widget overrides the
$.cleanData
method to also call.triggerHandler( "remove" )
method. According to Chrome's profiler, triggerHandler is a relatively slow method.When element is being removed with
$(elem).remove()
,$.cleanData
is called for each descendant element - and there can be thousands of those elements!This is an attempt to only execute
triggerHandler( "remove" )
for elements that are jQueryUI Widgets and skip that for all other elements.