Skip to content

jQuery.effects.define() #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 15 commits into from
Closed

jQuery.effects.define() #288

wants to merge 15 commits into from

Conversation

scottgonzalez
Copy link
Member

No description provided.

@scottgonzalez
Copy link
Member Author

I added jQuery.effects.scaledDimensions() to this PR.

@agcolom
Copy link
Member

agcolom commented Nov 27, 2015

Looks good :-) (i.e. no typo)

@scottgonzalez
Copy link
Member Author

I added jQuery.effects.clipToBox() and jQuery.effects.createPlaceholder() to this PR.

@scottgonzalez
Copy link
Member Author

I added jQuery.effects.removePlaceholder(), jQuery.effects.saveStyle(), and jQuery.effects.restoreStyle() to this PR.

@agcolom
Copy link
Member

agcolom commented Nov 27, 2015

All looks good :-)

jzaefferer
jzaefferer reviewed Nov 30, 2015
View reviewed changes
entries/jQuery.effects.saveStyle.xml
</signature>
<desc>Saves all inline styles applied to an element.</desc>
<longdesc>
<p>Saves all inline styles applied to an element. This is useful when animating various styles and restoring the existing styles at the end. The saved styles can be restored using <a href="/jQuery.effects.restoreStyle/"><code>jQuery.effects.restoreStyle()</code></a>.</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to explain what "save" means here. As far as I can tell it stores a copy of style.cssText via .data(), without making any changes to the styles itself.

Also applies to restoreStyle.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The how is pure internal details. The only thing the user should care about is how to restore the styles that have been saved, which is documented.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its not just internal details. The semantics of the method were unclear to me until I read the code, which makes for bad documentation.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain what semantics were unclear?

@jzaefferer
Copy link
Member

Apart from the underspecified saveStyle everything looks good.

@scottgonzalez
Copy link
Member Author

Updated the wording for saveStyle().

@jzaefferer
Copy link
Member

Looks good

scottgonzalez added a commit that referenced this pull request Dec 2, 2015
@scottgonzalez
jQuery.effects.define: Initial docs
a3c0b93 
Ref gh-242
Ref gh-288
scottgonzalez added a commit that referenced this pull request Dec 2, 2015
@scottgonzalez
jQuery.effects.scaledDimensions: Initial docs
8b35404 
Ref gh-242
Ref gh-288
scottgonzalez added a commit that referenced this pull request Dec 2, 2015
@scottgonzalez
jQuery.effects.clipToBox: Initial docs
50a4ef2 
Ref gh-242
Ref gh-288
scottgonzalez added a commit that referenced this pull request Dec 2, 2015
@scottgonzalez
jQuery.effects.createPlaceholder: Initial docs
2f26a9b 
Ref gh-242
Ref gh-288
scottgonzalez added a commit that referenced this pull request Dec 2, 2015
@scottgonzalez
jQuery.effects.removePlaceholder: Initial docs
c2ee7cb 
Ref gh-242
Ref gh-288
scottgonzalez added a commit that referenced this pull request Dec 2, 2015
@scottgonzalez
jQuery.effects.saveStyle: Initial docs
66171a1 
Ref gh-242
Ref gh-288
scottgonzalez added a commit that referenced this pull request Dec 2, 2015
@scottgonzalez
jQuery.effects.restoreStyle: Initial docs
6bf67d1 
Ref gh-242
Ref gh-288
@scottgonzalez
Copy link
Member Author

Merged into 1-12.

scottgonzalez added a commit that referenced this pull request Dec 17, 2015
@scottgonzalez
jQuery.effects.define: Initial docs
0b8e35c 
Ref gh-242
Ref gh-288
scottgonzalez added a commit that referenced this pull request Dec 17, 2015
@scottgonzalez
jQuery.effects.scaledDimensions: Initial docs
4b85611 
Ref gh-242
Ref gh-288
scottgonzalez added a commit that referenced this pull request Dec 17, 2015
@scottgonzalez
jQuery.effects.clipToBox: Initial docs
6ba1642 
Ref gh-242
Ref gh-288
scottgonzalez added a commit that referenced this pull request Dec 17, 2015
@scottgonzalez
jQuery.effects.createPlaceholder: Initial docs
5f0e014 
Ref gh-242
Ref gh-288
scottgonzalez added a commit that referenced this pull request Dec 17, 2015
@scottgonzalez
jQuery.effects.removePlaceholder: Initial docs
316d99b 
Ref gh-242
Ref gh-288
scottgonzalez added a commit that referenced this pull request Dec 17, 2015
@scottgonzalez
jQuery.effects.saveStyle: Initial docs
eb54654 
Ref gh-242
Ref gh-288
scottgonzalez added a commit that referenced this pull request Dec 17, 2015
@scottgonzalez
jQuery.effects.restoreStyle: Initial docs
867fb9f 
Ref gh-242
Ref gh-288
jzaefferer pushed a commit that referenced this pull request Jul 8, 2016
@scottgonzalez @jzaefferer
jQuery.effects.define: Initial docs
02e23ed 
Ref gh-242
Ref gh-288
jzaefferer pushed a commit that referenced this pull request Jul 8, 2016
@scottgonzalez @jzaefferer
jQuery.effects.scaledDimensions: Initial docs
7a68240 
Ref gh-242
Ref gh-288
jzaefferer pushed a commit that referenced this pull request Jul 8, 2016
@scottgonzalez @jzaefferer
jQuery.effects.clipToBox: Initial docs
d723519 
Ref gh-242
Ref gh-288
jzaefferer pushed a commit that referenced this pull request Jul 8, 2016
@scottgonzalez @jzaefferer
jQuery.effects.createPlaceholder: Initial docs
86c6965 
Ref gh-242
Ref gh-288
jzaefferer pushed a commit that referenced this pull request Jul 8, 2016
@scottgonzalez @jzaefferer
jQuery.effects.removePlaceholder: Initial docs
df6e53a 
Ref gh-242
Ref gh-288
jzaefferer pushed a commit that referenced this pull request Jul 8, 2016
@scottgonzalez @jzaefferer
jQuery.effects.saveStyle: Initial docs
87defba 
Ref gh-242
Ref gh-288
jzaefferer pushed a commit that referenced this pull request Jul 8, 2016
@scottgonzalez @jzaefferer
jQuery.effects.restoreStyle: Initial docs
9b3d827 
Ref gh-242
Ref gh-288
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@scottgonzalez @agcolom @jzaefferer @jquerybot