This repository was archived by the owner on Oct 8, 2021. It is now read-only.
Fix for issue 4882 #5221
Merged
Fix for issue 4882 #5221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behavior in browsers. This used to result in pages changing to "%20destination.html" instead of the now "destination.html". Fixes issue jquery-archive#4882
Conflicts: js/jquery.mobile.navigation.js
|
@jlembeck, thanks for the PR. That test passes without your patch to the regexp in Chrome 22 / OSX. Could you provide a test that fails with the code on master? |
|
This test fails without the code change and passes with it on Chrome 22/ OS X. Thanks @gseguin |
| $.mobile.changePage( " external.html" ); | ||
| }, | ||
| function(){ | ||
| ok( $.mobile.activePage.attr( "id" ) === "external-test", "the correct page is loaded" ); |
There was a problem hiding this comment.
Isn't equal more appropriate than ok here?
There was a problem hiding this comment.
Agreed. Change made.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the url parser's regular expression to eliminate any leading white space. Browsers ignore this space, so this is expected behavior. With the latest, it will create a 404. Before that, it would cause the next page to load without ajax.
This fixes issue #4882.