Skip to content
This repository was archived by the owner on Dec 11, 2021. It is now read-only.

[WIP] typography: added color variables #129

Closed

Conversation

xtina-starr
Copy link

fixes gh-119

coauthored with @theutahkate
This is a work in progress. We were curious if there was anything else within the _typography component that we could convert to use variables.

@jquerybot
Copy link

Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA).

📝 Please visit http://contribute.jquery.org/CLA/ to sign.

After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know.


If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check.

@sfrisk
Copy link
Contributor

sfrisk commented Oct 27, 2015

Just want to check to see how this is going, I know that @theutahkate was working on this Sunday of the jQuery Dev Summit.

@rohmulan
Copy link
Contributor

also seems like @xtina-starr will need to sign the CLA http://contribute.jquery.org/CLA/

@xtina-starr
Copy link
Author

I've signed it, but because I just have my first name on github it got
flagged as a suspicion name. Last I checked someone was suppose to manually
accept the CLA.

On Tuesday, October 27, 2015, Rohit Mulange notifications@github.com
wrote:

also seems like @xtina-starr https://github.com/xtina-starr will need
to sign the CLA http://contribute.jquery.org/CLA/


Reply to this email directly or view it on GitHub
#129 (comment).

Christina Thompson
www.christinasthompson.com
305-801-6561

@sfrisk
Copy link
Contributor

sfrisk commented Oct 27, 2015

@xtina-starr I'll contact the people in charge of the CLA to deal with it.

@theutahkate
Copy link

Arg! Sorry. Yes, I have a bunch of work done on it, and have been slammed
since I got back, so haven't touched it. I was intending to open a pr to replace @xtina-starr 's (since I can't push to her repo), which would get around the CLA problem for now, too. So let me do that, probably tonight.

On Tue, Oct 27, 2015 at 12:20 PM, Sarah Frisk notifications@github.com
wrote:

@xtina-starr https://github.com/xtina-starr I'll contact the people in
charge of the CLA to deal with it.


Reply to this email directly or view it on GitHub
#129 (comment).

@sfrisk
Copy link
Contributor

sfrisk commented Dec 15, 2015

Closing this in favor of the work continued in #134

@sfrisk sfrisk closed this Dec 15, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typography: Add jsass variables to typography
5 participants