Fix addAndroidDownloads for paths containing % #745
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this fix, specifying a path in the addAndroidDownloads option containing a "%" character would result in an error when downloading.
This is because in one place in the code when reading the path value, we assume the value is URI encoded, whereas in another place, we assume it is not URI encoded.
I updated the code to consistently assume the path is not URI encoded.
With this fix, downloading now works correctly for us for paths containing a "%" character when we specify the path unencoded.