Skip to content

Fix addAndroidDownloads for paths containing % #745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 23, 2022

Conversation

juliar
Copy link

@juliar juliar commented Sep 1, 2021

Before this fix, specifying a path in the addAndroidDownloads option containing a "%" character would result in an error when downloading.

This is because in one place in the code when reading the path value, we assume the value is URI encoded, whereas in another place, we assume it is not URI encoded.

I updated the code to consistently assume the path is not URI encoded.

With this fix, downloading now works correctly for us for paths containing a "%" character when we specify the path unencoded.

@retyui
Copy link

retyui commented Nov 11, 2021

Hi
This module is unmentionable ⚠️! please use fork: https://github.com/RonRadtke/react-native-blob-util

@rpenfold rpenfold merged commit 71fcebb into joltup:master Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants