wifi only option, and missing typings. #497
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thoughts on this? Does anyone review PRs? |
…, and this error ends up directly on the UI
…tor if not requested to
|
Also added a fix for #494 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new option:
wifiOnlyto the request config. The goal of this flag is to force requests to only go through WiFi interfaces.Rationale: Connect to IOT devices while also being connected to mobile/LTE data. Also useful when downloading large files and we don't want to download from mobile data.
Implemented for both Android and IOS, although the approach is slightly different on each one. For Android, SDK 21 or above is needed, and the setting will be ignored otherwise.
Should close #454