Updated Android build.gradle for RN 0.57 #176
Conversation
React Native 0.57 will [scaffold new projects using Gradle 3, instead of Gradle 2](facebook/react-native@6eac2d4). Users who install this library with Gradle 3 will see the following error: ``` Configuration 'compile' is obsolete and has been replaced with 'implementation' and 'api'. It will be removed at the end of 2018. For more information see: http://d.android.com/r/tools/update-dependency-configurations.html ``` This PR fixes this warning. Please note: this will cause any users who are still on Gradle 2 to see an error: ``` > Could not find method implementation() for arguments [com.facebook.react:react-native:+] on object of type org.gradle.api.internal.artifacts.dsl.dependencies.DefaultDependencyHandler. ``` This is because `implementation` is only available for users of Gradle 3. It may therefore be worth bumping the major version of this lib to indicate a breaking change for some users.
|
This PR also bumps the Android SDK compile/target version to 27, to match the forthcoming RN 0.57 release. |
|
It's a bit of a treadmill, but gradle plugin 3.2.0 is out, and support libs 27.1.1 are current for API27 |
|
Also need to add 'google()' to the dependencies for build + allprojects |
|
Guys, we need this changes so much, any update here? |
|
@Traviskn can you take a look into this? This is kinda important! |
|
react-native-share has already done something similar if you want to see what other RN modules have done - https://github.com/react-native-community/react-native-share/pull/373/files - but they moved to API 28, gradle 3.2.1 and the gradle wrappers and examples were updated as well. I could propose a similar PR (I authored that one) if you like, I use this library and I'm happy to help. RN-share released that as a point release and there hasn't been much blowback - just one user affected that needed to add an excludes stanza for android support libs |
|
we've updated to newer react native versions since this PR was opened |
Declaring excludeFromBackupKey in index.d.ts so it is accessible in typescript.
React Native 0.57 will scaffold new projects using Gradle 3, instead of Gradle 2.
Users who install this library with Gradle 3 will see the following error:
This PR fixes this warning.
Please note: this will cause any users who are still on Gradle 2 to see an error:
This is because
implementationis only available for users of Gradle 3.It may therefore be worth bumping the major version of this lib to indicate a breaking change for some users.