Skip to content

fix: prevent establishing ActiveRecord connection on startup #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 26, 2022
Merged

fix: prevent establishing ActiveRecord connection on startup #406

merged 1 commit into from
Oct 26, 2022

Conversation

milgner
Copy link
Contributor

@milgner milgner commented Feb 23, 2022

Instead of creating a connection and looking at its database adapter, look at the configured adapter instead.

This prevents issues when trying to compile assets or running other rake tasks in RAILS_ENV=production that are supposed to work without a running database.

@milgner
fix: prevent establishing ActiveRecord connection on startup
195be6d 
Instead of creating a connection and looking at its database adapter,
look at the configured adapter instead.
This prevents issues when trying to compile assets or running other
rake tasks in `RAILS_ENV=production` that are supposed to work without
a running database.
@milgner
Copy link
Contributor Author

milgner commented Feb 23, 2022

Updated the code to use ::ActiveRecord::Base.configurations.configs_for(env_name: Rails.env) instead which is more reliable.

@n-rodriguez
Copy link
Member

Fix #388

@aymeric-ledorze aymeric-ledorze mentioned this pull request Sep 23, 2022
Closed
@n-rodriguez n-rodriguez merged commit 76edb79 into jbox-web:master Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@milgner @n-rodriguez