This repository was archived by the owner on May 11, 2018. It is now read-only.
Adding automatic module name and removing java.net references #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arindam-bandyopadhyay
requested review from
bshannon,
romain-grecourt and
ldemichiel
bshannon
reviewed
Sep 12, 2017
README.md
Outdated
| @@ -0,0 +1,12 @@ | |||
| # Java(TM) Common Annotations | |||
|
|
|||
| The intention of Java(TM) Common Annotations is to to develop annotations for common semantic | |||
bshannon
reviewed
Sep 12, 2017
pom.xml
Outdated
|
|
||
| The contents of this file are subject to the terms of either the GNU | ||
| General Public License Version 2 only ("GPL") or the Common Development | ||
| and Distribution License("CDDL") (collectively, the "License"). You | ||
| may not use this file except in compliance with the License. You can | ||
| obtain a copy of the License at | ||
| https://glassfish.dev.java.net/public/CDDL+GPL_1_1.html | ||
| https://oss.oracle.com/licenses/CDDL+GPL-1.1 | ||
| or packager/legal/LICENSE.txt. See the License for the specific |
There was a problem hiding this comment.
Should be just "LICENSE.txt".
Better to copy and paste the entire header from a known good example instead of editing it by hand.
bshannon
reviewed
Sep 12, 2017
pom.xml
Outdated
| </issueManagement> | ||
| <mailingLists> | ||
| <mailingList> | ||
| <name>GlassFish Developer</name> | ||
| <archive>users@https://glassfish.java.net</archive> | ||
| <archive>glassfish@javaee.groups.io</archive> |
There was a problem hiding this comment.
Probably better to use javaee-spec@javaee.groups.io.
bshannon
approved these changes
Sep 12, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.