Skip to content

The secFracs field will support upto 12 chars #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 26, 2017

Conversation

huggsboson
Copy link
Member

@huggsboson huggsboson commented Mar 2, 2017

The secFracs field will support upto 12 chars

Fixes issue #143 opened by @rberger

The secFracs field will support upto 12 chars
@huggsboson
Copy link
Member Author

@daveclayton We created a branch of json-schema-core, json-schema-validator and json-patch while fge was away. I'm trying to get any patchsets we merged in the meantime upstream to you so we can get back onto the main branch. I'd expect a few more of these. Feel free to accept or reject depending on current context around the project.

@huggsboson huggsboson changed the title Fixes issue #143 opened by @rberger The secFracs field will support upto 12 chars Mar 2, 2017
@huggsboson huggsboson merged commit e83dfb6 into java-json-tools:master Apr 26, 2017
@huggsboson huggsboson deleted the SecFracs branch April 26, 2017 22:40
@namral
Copy link

namral commented May 1, 2017

When would this change be released ? We would definitely benefit from this fix

@huggsboson
Copy link
Member Author

I'm still trying to figure out what the releases will look like. @fge has gone off the grid so I may never be able to publish updated jars to com.github.fge. I will start looking into a new neutral group / artifact to publish to next week if francis hasn't gotten back to me. So hopefully sometime next week.

@msymons
Copy link

msymons commented May 3, 2017

Are you hoping for an actual release of json-schema-validator in the near future? I am hoping for #210 to make it into a release - fixing a security threat from libphonenumber and allowing me to do a PR to update swagger-compat-spec-parser

@huggsboson
Copy link
Member Author

I will be doing a release. I will probably not be able to update com.github.fge group / artifacts, so taking the upgrade will involve changing your packages.

@huggsboson
Copy link
Member Author

I will also merge your patchset :)

@tmack8001
Copy link

yes, thank you for taking over this project @huggsboson

@namral
Copy link

namral commented May 3, 2017

@huggsboson That is awesome ! Thank you 👍

@huggsboson
Copy link
Member Author

Hey folks, sorry for not publishing a build last week. A bunch of my daytime responsibilities caught up with me. I've got a maven central repo @ "com.github.java-json-tools". I need to get the signing stuff going and ideally get travis setup to publish and sign builds so getting an update is just a matter of merging.

@huggsboson
Copy link
Member Author

I'm targeting Wednesday or before to get a build up.

@huggsboson
Copy link
Member Author

Sorry for the long delay. A new version of the jar has been published with this fix and others in it. I'll be updating the readme and changelogs shortly.

@huggsboson
Copy link
Member Author

@tmack8001 @namral were either of you able to pull the new jars from the new locations and use them effectively?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants