Fix Development Docs & Maven JAR Build #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Leaving this for now. Will verify that this deploys to maven central correctly before merging. |
|
Looks great in staging. Will merge and deploy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docker compose setup in the development docs stopped working due to the addition of the javadocs and source jars.
Fixed the copy command in one of the Dockerfiles to resolve the issue.
Also found that the process for building JARs was flawed. Uber JAR creation just stopped working at random and this isn't the first time that's happened.
Switched to using maven-assembly-plugin and everything is working perfectly now.