1) Add a feature to disable a node. 2) Reduce around 400kB in the transpiled code. 3) Adding support to React node type (string or jsx tags) to the node label. #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: src/js/CheckboxTree.js src/js/TreeNode.js src/js/nodeShape.js
jakezatecky
requested changes
Jul 15, 2017
README.md
Outdated
| | `value` | mixed | **Required**. The node's value. | | ||
| | `children` | array | An array of child nodes. | | ||
| | `className` | string | A className to add to the node. | | ||
| | `icon` | mixed | A custom icon for the node. | | ||
| | `disabled` | bool | Disable node. | |
There was a problem hiding this comment.
I would prefer disabled to appear above icon and below className to be alphabetically sorted below the required properties.
| @@ -190,13 +190,14 @@ class CheckboxTree extends React.Component { | |||
| const key = `${node.value}`; | |||
| const checked = this.getCheckState(node, noCascade); | |||
| const children = this.renderChildNodes(node); | |||
| const nodeDisabled = !!(disabled || node.disabled); | |||
There was a problem hiding this comment.
Is there a reason the double negation is being used?
There was a problem hiding this comment.
Yes. The disabled property on TreeNode isRequired. The double negation will transform undefined to false.
|
Any update on this? Could really use it at the moment. |
jakezatecky
approved these changes
Sep 19, 2017
|
Soon. Might ship out a new release later this week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.