Skip to content
This repository was archived by the owner on Feb 12, 2024. It is now read-only.
This repository was archived by the owner on Feb 12, 2024. It is now read-only.

Encoding key names with base32 #1937

Closed
Closed
@AuHau

Description

@AuHau

Type: Enhacement

Description:

As part of my PR ipfs/kubo#6012 go-ipfs will be encoding key's names into base32 in order to unify behavior across all platforms (case sensitivity). As a small bonus because of it, it will be able to use any characters for the key's names (like namespacing for example "websites/some-website").

I assume that since js-ipfs has a goal to have interoperable repositories with go-ipfs, this behavior should be propagated from go-ipfs to js-ipfs as well.

I am happy to provide PR for js-ipfs as well.

I have a few questions.
Is this desired from your side? Will you accept the PR?
My idea of implementation of it would be to create something like EncodedDatastore wrapper that would be used in js-ipfs-repo for the keys property and would do the translation from/to base32.
I believe the base32 encoding won't be necessary for the datastore-level, should I hardwire exception for it or also encode it?

Metadata

Metadata

Assignees

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions