feat: support multiple roots #93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's never been clear why js-ipfs doesn't support multiple roots when go-ipfs does. This PR removes the check for multiple roots so if you import five files without a leading directory in their paths or with the `wrapWithDirectory` option, you'll get five CIDs back instead of an error.
hugomrdias
approved these changes
Nov 13, 2020
achingbrain
added a commit
that referenced
this pull request
Nov 17, 2020
It's never been clear why js-ipfs doesn't support multiple roots when go-ipfs does. This PR removes the check for multiple roots so if you import five files without a leading directory in their paths or with the `wrapWithDirectory` option, you'll get five CIDs back instead of an error. BREAKING CHANGE: Importing files that would result in multiple roots no longer throws an error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's never been clear why js-ipfs doesn't support multiple roots when
go-ipfs does.
This PR removes the check for multiple roots so if you import five
files without a leading directory in their paths or without the
wrapWithDirectoryoption, you'll get five CIDs back instead of an error.
BREAKING CHANGE: Importing files that would result in multiple roots no longer throws an error