fix: just do what the user asked #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We change some defaults based on the CID version passed, this seems like the wrong approach and debugging problems turns into whack-a-mole. Let the calling code decide the settings for the various knobs and levers instead. BREAKING CHANGES: We previously did things like set rawLeaves to true based on the CID version, now we do not.
|
Will need a follow-up PR to js-ipfs to replicate these settings. |
hugomrdias
approved these changes
Nov 6, 2020
|
It shouldn't do, as long as we replicate the settings overriding in IPFS, which we will. It will affect anyone using the importer directly, but this will go out as a major. |
achingbrain
added a commit
that referenced
this pull request
Nov 6, 2020
We change some defaults based on the CID version passed, this seems like the wrong approach and debugging problems turns into whack-a-mole. Let the calling code decide the settings for the various knobs and levers instead. BREAKING CHANGE: We previously did things like set rawLeaves to true based on the CID version, now we do not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We change some defaults based on the CID version passed, this seems
like the wrong approach and debugging problems turns into whack-a-mole.
Let the calling code decide the settings for the various knobs and levers
instead.
BREAKING CHANGES: We previously did things like set rawLeaves to true based
on the CID version, now we do not.