fix: mask file mode #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only expose documented bits to calling code but respect them when turning the entry into a protobuf.
|
cc @ribasushi |
alanshaw
approved these changes
Dec 19, 2019
ribasushi
reviewed
Dec 20, 2019
| @@ -80,7 +80,8 @@ class Data { | |||
| this.fanout = fanout | |||
| this.blockSizes = blockSizes || [] | |||
| this.mtime = mtime || new Date(0) | |||
| this.mode = mode | |||
| this.mode = mode || mode === 0 ? (mode & 0xFFF) : undefined | |||
There was a problem hiding this comment.
@achingbrain just want to doublecheck I am reading the precedence right. Are you saying:
assign
mode & 0xFFFIFmode is non-zero numeric ( truthy) OR literal 0OTHERWISEundefined
The rest looks great
There was a problem hiding this comment.
Yes, that's correct, truthy or literal 0
ribasushi
approved these changes
Dec 20, 2019
hugomrdias
approved these changes
Dec 22, 2019
achingbrain
added a commit
that referenced
this pull request
Feb 19, 2020
* feat: support storing metadata in unixfs nodes
Adds `mtime` and `mode` properties to `{path, content}` import entries
* chore: remove gh url
* chore: upgrade node
* chore: update deps
* fix: add metadata to directories too
* fix: add metadata to imported directories
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only expose documented bits to calling code but respect them when turning the entry into a protobuf.
Implements ipfs/specs#231