fix: support setting mode to 0 #37
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current version of `proton` can't differentiate between a field that was set to 0 or not set at all. We need this to not have `mode` revert to it's default value when we set it to `0`, which is valid although of little use. Depends on ipfs/protons#8
This was referenced Nov 21, 2019
alanshaw
approved these changes
Nov 22, 2019
hugomrdias
approved these changes
Nov 23, 2019
|
Superseded by #38 |
achingbrain
pushed a commit
that referenced
this pull request
Feb 19, 2020
ipld-dag-pb got a new release with breaking changes, update to that release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current version of
protonscan't differentiate between a field that was set to 0 or not set at all. We need this to not havemoderevert to it's default value when we set it to0, which is valid although of little use.Depends on ipfs/protons#8