Skip to content

lock-memory - won't fail if lock already exists #194

Closed
@AuHau

Description

@AuHau

While working on the repo migration tool, I have noticed that the implementation of in-memory lock in lock-memory.js behaves in bit weird way as it will acquire lock even if there is already lock in place.
It exposes function locked(), yet I have not found it used anywhere. But even then I think the correct behavior of any locking functionality should be to fail when there is a lock already present.

I understand that in browser there might not be really concurrent processes, so I am just wondering if that was a design decision or is it a bug?

Metadata

Metadata

Assignees

No one assigned

    Labels

    P3Low: Not priority right nowexp/noviceSomeone with a little familiarity can pick uphelp wantedSeeking public contribution on this issuekind/bugA bug in existing code (including security flaws)status/readyReady to be worked

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions