feat!: define rule for consistent type import style #263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prefer:
```ts
import type { Foo } from 'bar'
```
over
```ts
import { type Foo } from 'bar'
```
After compilation it doesn't make any difference but it would be good to settle on one style or the other.
BREAKING CHANGE: type import style is now specified, re-run linting with `--fix` to patch up any rule violations
achingbrain
changed the title
github-actions bot
pushed a commit
that referenced
this pull request
Apr 30, 2025
## [8.0.0](v7.0.6...v8.0.0) (2025-04-30) ### ⚠ BREAKING CHANGES * type import style is now specified, re-run linting with `--fix` to patch up any rule violations ### Features * define rules for consistent type import style ([#263](#263)) ([948ce47](948ce47)) ### Trivial Changes * fix ci ([dbd1afc](dbd1afc))
|
🎉 This PR is included in version 8.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prefer:
over
After compilation it doesn't make any difference but it would be good to settle on one style or the other.Turns out it does, the former gets removed entirely, the latter compiles to:
..which can lead to runtime failures if
baris only a devdep of the project (recommended by definitely typed for@types/bar-style dependencies.BREAKING CHANGE: type import style is now specified, re-run linting with
--fixto patch up any rule violations