Skip to content
This repository was archived by the owner on Apr 29, 2020. It is now read-only.

chore: require 0.15.2 of ipld-dag-pb to have name memoisation #7

Merged
merged 2 commits into from
Dec 19, 2018

Conversation

achingbrain
Copy link
Collaborator

No description provided.

@ghost ghost assigned achingbrain Dec 19, 2018
@ghost ghost added the in progress label Dec 19, 2018
@achingbrain achingbrain requested a review from vmx December 19, 2018 12:41
@vmx
Copy link
Contributor

vmx commented Dec 19, 2018

You might want to explicitly also upgrade to the just release ipld 0.20.2.

@achingbrain
Copy link
Collaborator Author

Do you think these should have been minors?

@vmx
Copy link
Contributor

vmx commented Dec 19, 2018

For dag-pb I'm not sure anymore. After your comment that it might lead to issues if you have two different versions installed. On the other hand, if that's a bugfix release all dependencies will automatically move to it, so it's less likely we end up with two different versions.

For js-ipld: I tested with js-ipfs and it didn't break anything, so I think it's good to go. I keep sub 1.0.0 minor releases for breaking changes and I haven't seen why anything should break.

@vmx
Copy link
Contributor

vmx commented Dec 19, 2018

So I kind of do manual pre 1.0.0 automatic seantic-release. If there is no "BREAKING CHANGE" commit, it won't be a minor.

@achingbrain
Copy link
Collaborator Author

I think we should move everything to v1, but that's another conversation.

The weird case we've encountered is that ipld-dag-pb@0.15.2 is API compatible with ipld-dag-pb@0.15.1 but runtime incompatible.

all dependencies will automatically move to it

I believe this is only true if you have no package-lock.json present, otherwise it'll happily resolve 0.15.0 for ~0.15.0 even if 0.15.2 is available.

@vmx
Copy link
Contributor

vmx commented Dec 19, 2018

I believe this is only true if you have no package-lock.json present, otherwise it'll happily resolve 0.15.0 for ~0.15.0 even if 0.15.2 is available.

Thanks for that information. So it works for CI, but not it real world.

@achingbrain achingbrain merged commit cb3f6c5 into master Dec 19, 2018
@achingbrain achingbrain deleted the update-deps branch December 19, 2018 13:13
@ghost ghost removed the in progress label Dec 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants