This repository was archived by the owner on Apr 29, 2020. It is now read-only.
feat: add fullPath option
#3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
daviddias
reviewed
Nov 22, 2018
| const collect = require('pull-stream/sinks/collect') | ||
|
|
||
| pull( | ||
| exporter('QmFoo.../bar/baz.txt', ipld, { |
There was a problem hiding this comment.
For the sake of greater clarity, can we s/ipld/graphService? //cc @vmx
There was a problem hiding this comment.
I would go with ipld for now until there's really something other than IPLD.
achingbrain
force-pushed
the
add-full-path-option
branch
from
444a5d3 to
e4f57cc
Compare
When exporting a path with a subtree it's sometimes useful to get information about everything in the path and not just the node at the end. This PR adds an option to return intermediate nodes in the export stream. It also documents the `maxDepth` option and lowers the sharding threshold to make the shard tests more reliable in the browser.
achingbrain
force-pushed
the
add-full-path-option
branch
from
e4f57cc to
21dd221
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When exporting a path with a subtree it's sometimes useful to get information about everything in the path and not just the node at the end.
This PR adds an option to return intermediate nodes in the export stream.
It also documents the
maxDepthoption and lowers the sharding threshold to make the shard tests more reliable in the browser.