Skip to content
This repository was archived by the owner on Aug 12, 2020. It is now read-only.

chore: fix dependencies #231

Merged
merged 1 commit into from
Oct 24, 2018
Merged

chore: fix dependencies #231

merged 1 commit into from
Oct 24, 2018

Conversation

vmx
Copy link
Contributor

@vmx vmx commented Oct 22, 2018

After running

dependency-check ./package.json --missing --no-dev
dependency-check ./package.json --unused --no-dev
dependency-check ./package.json --missing ./test/*
dependency-check ./package.json --unused ./test/*

I found out that some dependencies are not quite right. This commit
fixes them.

@vmx vmx requested a review from achingbrain October 22, 2018 19:24
@ghost ghost assigned vmx Oct 22, 2018
@ghost ghost added the status/in-progress In progress label Oct 22, 2018
@achingbrain
Copy link
Collaborator

Neat, thanks.

It looks like you've specified the version of mkdirp as "^0.5.1". To get Aegir's dependency version linting to pass it should be "~0.5.1".

After running

    dependency-check ./package.json --missing --no-dev
    dependency-check ./package.json --unused --no-dev
    dependency-check ./package.json --missing ./test/*
    dependency-check ./package.json --unused ./test/*

I found out that some dependencies are not quite right. This commit
fixes them.
@vmx vmx force-pushed the fix-dependencies branch from 96b45c7 to 0a92500 Compare October 23, 2018 11:22
@vmx
Copy link
Contributor Author

vmx commented Oct 23, 2018

@achingbrain I've forced push a new commit with a fix.

@achingbrain achingbrain merged commit df6c526 into master Oct 24, 2018
@ghost ghost removed the status/in-progress In progress label Oct 24, 2018
@achingbrain achingbrain deleted the fix-dependencies branch October 24, 2018 08:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants