This repository was archived by the owner on Aug 12, 2020. It is now read-only.
fix: return cids from builder #220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enforces CID Version 1 for non-sha2-256 hash algorithms and returns the buffer that makes up the CID instead of the buffer that makes up the multihash. Returning the multihash for v0 CIDs is fine because the codec and version are implicity but if we want to be able to load DAGNodes stored with a v1 CID, we need to return the CID buffer instead.
ghost
assigned 
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enforces CID Version 1 for non-sha2-256 hash algorithms and returns the buffer that makes up the CID instead of the buffer that makes up the multihash.
Returning the multihash for v0 CIDs is fine because the codec and version are implicity but if we want to be able to load DAGNodes stored with a v1 CID, we need to return the CID buffer instead.