This repository was archived by the owner on Mar 10, 2020. It is now read-only.
test: allow for easier mocking of requests #837
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Jacob Heun <jacobheun@gmail.com>
ghost
assigned 
|
For reference, testing in libp2p, here is a failed build of me using nock without this change https://ci.ipfs.team/blue/organizations/jenkins/libp2p%2Fjs-libp2p/detail/feat%2Fpeer-content-routing/3/pipeline And an all green build of this branch using package.json |
alanshaw
approved these changes
Aug 21, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way
http.requestis currently being included makes it a huge pain to mock the api requests with something likenock, since the request function cannot be stubbed the way it's being included.This PR changes the way .request is being included, to allow for easier mocking.
I am using this change locally with nock to test some upcoming module additions to libp2p.