This repository was archived by the owner on Mar 10, 2020. It is now read-only.
fix(pubsub): callback from unsubscribe after stream ends #772
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the
unsubscribe
logic to only callback on the last event we can listen for on a dropped connection.This still does not guarantee that your topic won't appear when calling
pubsub.ls
in the callback topubsub.unsubscribe
- but only when talking to go-ipfs.Adding an artificial timeout using
setTimeout
seems to provide enough time for go-ipfs to actually do the unsubscribe.