Skip to content
This repository was archived by the owner on Mar 10, 2020. It is now read-only.

feat: Add offset/length arguments to files.cat #734

Merged
merged 2 commits into from
Apr 24, 2018

Conversation

@daviddias
Copy link
Contributor

@achingbrain can you check on why CI is failing terribly ?

@achingbrain achingbrain force-pushed the add-stream-slicing-to-api branch from 3aa50e2 to 33c973a Compare April 23, 2018 14:19
@achingbrain
Copy link
Collaborator Author

achingbrain commented Apr 23, 2018

@diasdavid It's looking slightly healthier now but will need the fixes from #746 and ipfs-inactive/interface-js-ipfs-core#258

I encountered some problems with duplicated dependencies while working on multiple libraries simultaneously and ~ and ^ are used interchangeably. Do you think we could standardise on one or the other across all js-ipfs projects? Better yet, can we release v1 of all modules that are currently 0.x?

@daviddias daviddias force-pushed the add-stream-slicing-to-api branch from 33c973a to bd81b27 Compare April 24, 2018 08:41
@daviddias
Copy link
Contributor

I encountered some problems with duplicated dependencies while working on multiple libraries simultaneously and ~ and ^ are used interchangeably. Do you think we could standardise on one or the other across all js-ipfs projects? Better yet, can we release v1 of all modules that are currently 0.x?

Our rule is: Use ~ for everything below 1.0.0 and ^ for everything above 1.0.0. If you find a package.json that is not following this rule, please submit a PR.

As for v1 of all the modules. We've discussed it in the past and agreed that until IPFS reaches 1.0.0, we won't be releasing 1.0.0 modules.

@daviddias daviddias merged commit f4acdee into master Apr 24, 2018
@daviddias daviddias deleted the add-stream-slicing-to-api branch April 24, 2018 08:49
@ghost ghost removed the in progress label Apr 24, 2018
@achingbrain
Copy link
Collaborator Author

until IPFS reaches 1.0.0, we won't be releasing 1.0.0 modules

What's stopping IPFS from reaching v1?

@daviddias
Copy link
Contributor

Many things -- https://github.com/ipfs/ipfs/blob/master/ROADMAP-TO-1.0.0.md --, the first questions should be, what is missing to reach Beta, see ipfs/ipfs#314

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants