This repository was archived by the owner on Mar 10, 2020. It is now read-only.
Make url-add follow HTTP redirections #514
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/api/util/url-add.js
Outdated
|
|
||
| const redirection = res.headers.location | ||
|
|
||
| if (redirection) { |
There was a problem hiding this comment.
This should also check for the right redirection header.
There was a problem hiding this comment.
Which header is that if not location? That's the header in the spec and that seem to be used by the request module too.
There was a problem hiding this comment.
I'm sorry, I meant the status code
There was a problem hiding this comment.
Indeed. I'm adding a commit to cover that
|
Why is this not part of node core... |
|
@maxlath mind doing a rebase of master into this branch? |
|
@diasdavid rebase done! plus, I added a test 78c0537 |
|
@maxlath mind fixing lint? Looks like that is the last step to get this done :) |
|
@diasdavid done! 08f785a |
daviddias
approved these changes
Aug 6, 2017
|
awesome, thanks @maxlath :D |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #513
That's the shortest path I found to solve this issue, but different solutions could be considered:
request.jswreck