This repository was archived by the owner on Mar 10, 2020. It is now read-only.
Handle directories with odd names #456
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, adding a directory with square brackets resulted in a strange, silent error [1]. This happened because directory names were being passed to a file- matching glob designed to recursively stream files from the directory. When filenames contained meaningful glob symbols (like [ or *), the glob matching would fail. This commit resolves this problem by escaping glob characters on filenames, before the filename is inserted into the main glob in src/get-file-streams.js L48. We add a dependency to glob-escape in the process, and a new test in test/ipfs-api/util.spec.js.
|
awesome @elsehow! thank you for fixing this :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, adding a directory with square brackets
resulted in a strange, silent error. This happened
because directory names were being passed to a file-
matching glob designed to recursively stream files from
the directory. When filenames contained meaningful glob
symbols (like [ or *), the glob matching would fail.
This commit resolves this problem by escaping glob
characters on filenames, before the filename is inserted
into the main glob in src/get-file-streams.js L48.
We add a dependency to glob-escape in the process,
and a new test in test/ipfs-api/util.spec.js.