This repository was archived by the owner on Mar 10, 2020. It is now read-only.
fix: handle missing daemon errors #445
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pfrazee this seems to solve your issue, want to try it out? |
|
Yeah that solved it! Thanks |
| @@ -147,6 +147,10 @@ function requestAPI (config, options, callback) { | |||
| headers: headers | |||
| }, onRes(options.buffer, callback)) | |||
|
|
|||
| req.on('error', (err) => { | |||
| callback(err) | |||
There was a problem hiding this comment.
you should use to avoid having double callback calls
const once = require('once')
callback = once(callback)There was a problem hiding this comment.
it is already done, see above :)
This was referenced Nov 24, 2016
|
thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.