This repository was archived by the owner on Mar 10, 2020. It is now read-only.
Enhancement: Implement Bootstrap API #298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| describe('.list', () => { | ||
| it('returns a list of peers', (done) => { | ||
| return apiClients.a.bootstrap.list(null, (err, res) => { |
There was a problem hiding this comment.
Why do we need the null arg?
There was a problem hiding this comment.
Great question.....we don't
There was a problem hiding this comment.
Can we take it off then?
There was a problem hiding this comment.
Of course! Was away from my machine yesterday - should have mentioned in the note that I'd update the pr within the day. It's up now :)
|
Awesome work @gavinmcdermott ! :D left a couple of questions |
|
LGTM :) Thank you @gavinmcdermott Could you squash the commits for the merge? |
gavinmcdermott
force-pushed
the
feat/implement_bootstrap
branch
from
8099f6e to
f8aa5ed
Compare
| return apiClients.a.bootstrap.add(null) | ||
| .catch((err) => { | ||
| expect(err).to.be.an.instanceof(Error) | ||
| done() |
There was a problem hiding this comment.
You can drop the done in all the promise tests, mocha detects that you return a promise (also need to remove it from the function signature.
gavinmcdermott
force-pushed
the
feat/implement_bootstrap
branch
from
f8aa5ed to
2a62e1e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the bootstrap API in reference to issue #217 raised by @diasdavid