This repository was archived by the owner on Mar 10, 2020. It is now read-only.
feature - createAddStream #291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daviddias
force-pushed
the
feature/createAddStream
branch
from
b6292c2 to
223e456
Compare
|
daviddias
force-pushed
the
feature/createAddStream
branch
from
223e456 to
5012484
Compare
| }) | ||
| } | ||
| callback(null, ds) | ||
| }) |
There was a problem hiding this comment.
Are errors handled somewhere?
There was a problem hiding this comment.
good catch, tahnk you. Emitted the error upstream :)
|
One question re. error handling, otherwise LGTM |
daviddias
force-pushed
the
feature/createAddStream
branch
from
5012484 to
d821abb
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.