Replace assert with chai

package.json

@@ -29,6 +29,7 @@
     "babel-plugin-transform-runtime": "^6.1.18",
     "babel-preset-es2015": "^6.0.15",
     "babel-runtime": "^5.8.34",
+    "chai": "^3.4.1",
     "concurrently": "^1.0.0",
     "eslint-config-standard": "^4.4.0",
     "eslint-plugin-standard": "^1.3.1",

src/api/dht.js

@@ -24,7 +24,8 @@ module.exports = send => {
         if (res.Type === 5) {
           cb(null, res.Extra)
         } else {
-          cb(res)
+          let error = new Error('key was not found (type 6)')
+          cb(error)
         }
       })
     },

test/.eslintrc

@@ -5,6 +5,6 @@
   "globals": {
     "apiClients": true,
     "isNode": true,
-    "assert": true
+    "expect": true
   }
 }

test/api/add.spec.js

@@ -34,23 +34,21 @@ describe('.add', () => {
     })
 
     apiClients['a'].add(file, (err, res) => {
-      if (err) throw err
+      expect(err).to.not.exist
 
       const added = res[0] != null ? res[0] : res
-      assert.equal(added.Hash, 'Qma4hjFTnCasJ8PVp3mZbZK5g2vGDT4LByLJ7m8ciyRFZP')
-      assert.equal(added.Name, path.basename(testfilePath))
+      expect(added).to.have.property('Hash', 'Qma4hjFTnCasJ8PVp3mZbZK5g2vGDT4LByLJ7m8ciyRFZP')
+      expect(added).to.have.property('Name', path.basename(testfilePath))
       done()
     })
   })
 
   it('add buffer', done => {
     let buf = new Buffer(testfile)
     apiClients['a'].add(buf, (err, res) => {
-      if (err) throw err
-
-      assert.equal(res.length, 1)
-      const added = res[0]
-      assert.equal(added.Hash, 'Qma4hjFTnCasJ8PVp3mZbZK5g2vGDT4LByLJ7m8ciyRFZP')
+      expect(err).to.not.exist
+      expect(res).to.have.length(1)
+      expect(res[0]).to.have.property('Hash', 'Qma4hjFTnCasJ8PVp3mZbZK5g2vGDT4LByLJ7m8ciyRFZP')
       done()
     })
   })
@@ -61,11 +59,9 @@ describe('.add', () => {
     }
 
     apiClients['a'].add(testfileBig, (err, res) => {
-      if (err) throw err
-
-      assert.equal(res.length, 1)
-      const added = res[0]
-      assert.equal(added.Hash, 'Qme79tX2bViL26vNjPsF3DP1R9rMKMvnPYJiKTTKPrXJjq')
+      expect(err).to.not.exist
+      expect(res).to.have.length(1)
+      expect(res[0]).to.have.a.property('Hash', 'Qme79tX2bViL26vNjPsF3DP1R9rMKMvnPYJiKTTKPrXJjq')
       done()
     })
   })
@@ -76,24 +72,24 @@ describe('.add', () => {
     }
 
     apiClients['a'].add(testfilePath, (err, res) => {
-      if (err) throw err
+      expect(err).to.not.exist
 
       const added = res[0] != null ? res[0] : res
-      assert.equal(added.Hash, 'Qma4hjFTnCasJ8PVp3mZbZK5g2vGDT4LByLJ7m8ciyRFZP')
+      expect(added).to.have.property('Hash', 'Qma4hjFTnCasJ8PVp3mZbZK5g2vGDT4LByLJ7m8ciyRFZP')
       done()
     })
   })
 
   it('add a nested dir', done => {
     apiClients['a'].add(__dirname + '/../test-folder', { recursive: true }, (err, res) => {
       if (isNode) {
-        if (err) throw err
+        expect(err).to.not.exist
 
         const added = res[res.length - 1]
-        assert.equal(added.Hash, 'QmSzLpCVbWnEm3XoTWnv6DT6Ju5BsVoLhzvxKXZeQ2cmdg')
+        expect(added).to.have.property('Hash', 'QmSzLpCVbWnEm3XoTWnv6DT6Ju5BsVoLhzvxKXZeQ2cmdg')
         done()
       } else {
-        assert.equal(err.message, 'Recursive uploads are not supported in the browser')
+        expect(err.message).to.be.equal('Recursive uploads are not supported in the browser')
         done()
       }
     })
@@ -104,21 +100,21 @@ describe('.add', () => {
     stream.push('Hello world')
     stream.push(null)
     apiClients['a'].add(stream, (err, res) => {
-      if (err) throw err
+      expect(err).to.not.exist
 
       const added = res[0] != null ? res[0] : res
-      assert.equal(added.Hash, 'QmNRCQWfgze6AbBCaT1rkrkV5tJ2aP4oTNPb5JZcXYywve')
+      expect(added).to.have.a.property('Hash', 'QmNRCQWfgze6AbBCaT1rkrkV5tJ2aP4oTNPb5JZcXYywve')
       done()
     })
   })
 
   it('add url', done => {
     const url = 'https://raw.githubusercontent.com/ipfs/js-ipfs-api/2a9cc63d7427353f2145af6b1a768a69e67c0588/README.md'
     apiClients['a'].add(url, (err, res) => {
-      if (err) throw err
+      expect(err).to.not.exist
 
       const added = res[0] != null ? res[0] : res
-      assert.equal(added.Hash, 'QmZmHgEX9baxUn3qMjsEXQzG6DyNcrVnwieQQTrpDdrFvt')
+      expect(added).to.have.a.property('Hash', 'QmZmHgEX9baxUn3qMjsEXQzG6DyNcrVnwieQQTrpDdrFvt')
       done()
     })
   })

test/api/block.spec.js

@@ -6,22 +6,21 @@ describe('.block', () => {
 
   it('block.put', done => {
     apiClients['a'].block.put(blorb, (err, res) => {
-      if (err) throw err
-      const store = res.Key
-      assert.equal(store, 'QmPv52ekjS75L4JmHpXVeuJ5uX2ecSfSZo88NSyxwA3rAQ')
+      expect(err).to.not.exist
+      expect(res).to.have.a.property('Key', 'QmPv52ekjS75L4JmHpXVeuJ5uX2ecSfSZo88NSyxwA3rAQ')
       done()
     })
   })
 
   it('block.get', done => {
     apiClients['a'].block.get(blorbKey, (err, res) => {
-      if (err) throw err
+      expect(err).to.not.exist
 
       let buf = ''
       res
         .on('data', function (data) { buf += data })
         .on('end', function () {
-          assert.equal(buf, 'blorb')
+          expect(buf).to.be.equal('blorb')
           done()
         })
     })

test/api/cat.spec.js

@@ -15,16 +15,14 @@ if (isNode) {
 describe('.cat', () => {
   it('cat', done => {
     apiClients['a'].cat('Qma4hjFTnCasJ8PVp3mZbZK5g2vGDT4LByLJ7m8ciyRFZP', (err, res) => {
-      if (err) {
-        throw err
-      }
+      expect(err).to.not.exist
 
       let buf = ''
       res
         .on('error', err => { throw err })
         .on('data', data => buf += data)
         .on('end', () => {
-          assert.equal(buf, testfile)
+          expect(buf).to.be.equal(testfile.toString())
           done()
         })
     })
@@ -36,16 +34,14 @@ describe('.cat', () => {
     }
 
     apiClients['a'].cat('Qme79tX2bViL26vNjPsF3DP1R9rMKMvnPYJiKTTKPrXJjq', (err, res) => {
-      if (err) {
-        throw err
-      }
+      expect(err).to.not.exist
 
       testfileBig = require('fs').createReadStream(__dirname + '/../15mb.random', { bufferSize: 128 })
 
       // Do not blow out the memory of nodejs :)
       streamEqual(res, testfileBig, (err, equal) => {
-        if (err) throw err
-        assert(equal)
+        expect(err).to.not.exist
+        expect(equal).to.be.true
         done()
       })
     })

test/api/commands.spec.js

@@ -3,10 +3,8 @@
 describe('.commands', () => {
   it('lists commands', done => {
     apiClients['a'].commands((err, res) => {
-      if (err) {
-        throw err
-      }
-      assert(res)
+      expect(err).to.not.exist
+      expect(res).to.exist
       done()
     })
   })

test/api/config.spec.js

@@ -6,22 +6,19 @@ describe('.config', () => {
     const confVal = 'arbitraryVal'
 
     apiClients['a'].config.set(confKey, confVal, (err, res) => {
-      if (err) throw err
+      expect(err).to.not.exist
       apiClients['a'].config.get(confKey, (err, res) => {
-        if (err) throw err
-        assert.equal(res.Value, confVal)
+        expect(err).to.not.exist
+        expect(res).to.have.a.property('Value', confVal)
         done()
       })
     })
   })
 
   it('.config.show', done => {
     apiClients['c'].config.show((err, res) => {
-      if (err) {
-        throw err
-      }
-
-      assert(res)
+      expect(err).to.not.exist
+      expect(res).to.exist
       done()
     })
   })
@@ -32,11 +29,8 @@ describe('.config', () => {
     }
 
     apiClients['c'].config.replace(__dirname + '/../r-config.json', (err, res) => {
-      if (err) {
-        throw err
-      }
-
-      assert.equal(res, null)
+      expect(err).to.not.exist
+      expect(res).to.be.equal(null)
       done()
     })
   })

test/api/dht.spec.js

@@ -4,42 +4,35 @@ describe('.dht', () => {
   it('returns an error when getting a non-existent key from the DHT',
      done => {
        apiClients['a'].dht.get('non-existent', {timeout: '100ms'}, (err, value) => {
-         assert(err)
+         expect(err).to.be.an.instanceof(Error)
          done()
        })
      })
 
   it('puts and gets a key value pair in the DHT', done => {
     apiClients['a'].dht.put('scope', 'interplanetary', (err, res) => {
-      if (err) {
-        throw err
-      }
+      expect(err).to.not.exist
 
-      assert.equal(typeof res, 'object')
+      expect(res).to.be.an('array')
 
-      return done()
+      done()
 
       // non ipns or pk hashes fail to fetch, known bug
       // bug: https://github.com/ipfs/go-ipfs/issues/1923#issuecomment-152932234
       // apiClients['a'].dht.get('scope', (err, value) => {
       //  console.log('->>', err, value)
-      //  if (err) {
-      //    throw err
-      //  }
-      //  assert.equal(value, 'interplanetary')
+      //  expect(err).to.not.exist
+      //  expect(value).to.be.equal('interplanetary')
       //  done()
       // })
     })
   })
 
   it('.dht.findprovs', done => {
     apiClients['a'].dht.findprovs('Qma4hjFTnCasJ8PVp3mZbZK5g2vGDT4LByLJ7m8ciyRFZP', (err, res) => {
-      if (err) {
-        throw err
-      }
+      expect(err).to.not.exist
 
-      assert.equal(typeof res, 'object')
-      assert(res)
+      expect(res).to.be.an('array')
       done()
     })
   })

test/api/diag.spec.js

@@ -3,22 +3,18 @@
 describe('.diag', () => {
   it('.diag.net', done => {
     apiClients['a'].diag.net((err, res) => {
-      if (err) {
-        throw err
-      }
-      assert(res)
+      expect(err).to.not.exist
+      expect(res).to.exist
       done()
     })
   })
 
   it('.diag.sys', done => {
     apiClients['a'].diag.sys((err, res) => {
-      if (err) {
-        throw err
-      }
-      assert(res)
-      assert(res.memory)
-      assert(res.diskinfo)
+      expect(err).to.not.exist
+      expect(res).to.exist
+      expect(res).to.have.a.property('memory')
+      expect(res).to.have.a.property('diskinfo')
       done()
     })
   })

test/api/id.spec.js

@@ -3,10 +3,9 @@
 describe('.id', () => {
   it('id', done => {
     apiClients['a'].id((err, res) => {
-      if (err) throw err
-      const id = res
-      assert(id.ID)
-      assert(id.PublicKey)
+      expect(err).to.not.exist
+      expect(res).to.have.a.property('ID')
+      expect(res).to.have.a.property('PublicKey')
       done()
     })
   })

test/api/index.spec.js

@@ -2,7 +2,7 @@
 
 describe('API', () => {
   it('has the api object', () => {
-    assert(apiClients['a'])
-    assert(apiClients['a'].id)
+    expect(apiClients['a']).to.exist
+    expect(apiClients['a']).to.have.a.property('id')
   })
 })

test/api/log.spec.js

@@ -3,12 +3,10 @@
 describe('.log', () => {
   it('.log.tail', done => {
     apiClients['a'].log.tail((err, res) => {
-      if (err) {
-        throw err
-      }
+      expect(err).to.not.exist
+
       res.once('data', obj => {
-        assert(obj)
-        assert.equal(typeof obj, 'object')
+        expect(obj).to.be.an('object')
         done()
       })
     })

test/api/name.spec.js

@@ -5,23 +5,20 @@ describe('.name', () => {
 
   it('.name.publish', done => {
     apiClients['a'].name.publish('Qma4hjFTnCasJ8PVp3mZbZK5g2vGDT4LByLJ7m8ciyRFZP', (err, res) => {
-      if (err) {
-        throw err
-      }
-      assert(res)
+      expect(err).to.not.exist
       name = res
+      expect(name).to.exist
       done()
     })
   })
 
   it('.name.resolve', done => {
     apiClients['a'].name.resolve(name.Name, (err, res) => {
-      if (err) {
-        throw err
-      }
-
-      assert(res)
-      assert.deepEqual(res, { Path: '/ipfs/' + name.Value })
+      expect(err).to.not.exist
+      expect(res).to.exist
+      expect(res).to.be.eql({
+        Path: '/ipfs/' + name.Value
+      })
       done()
     })
   })