Awesome progress bar endeavor

[dryajov]

This issues is here to track the progress bar functionality effort

Tasks required to complete this endeavor:

• Document this feature in spec https://github.com/ipfs/interface-ipfs-core/tree/master/API/files#files-api
• Create big file and directory tests
• Move tests to https://github.com/ipfs/interface-ipfs-core/tree/master/src
• Test against js-ipfs too
• Make sure that when linked, js-ipfs CLI picks up on this to show the progress bar.

Relevant PRs

Name	Ready for Review	Reviewed	Merged	Published
interface-ipfs-core	✅	✅	✅	✅
js-ipfs	✅	✅	✅	❌
js-ipfs-api	✅	✅	✅	✅

Additional notes

With the introduction of errors through the Trailer header, we have ran into an issue described here -
#607. This shouldn't block this endeavor, but should be resolved ASAP.

Tagging @diasdavid

[victorb]

Updated the table to reflect that the interface-ipfs-core tests have been merged and published already.

[dryajov]

We'll need to make another release of interface-ipfs-core tho, there are some discrepancies with js-ipfs and go-ipfs reporting that I let slip, which cause the tests fail under js-ipfs. I have a patch coming soon.

[dryajov]

@diasdavid

This issue (ipfs/js-ipfs#1036), is also ready for another review pass. In general, all required functionality has been implemented and tests are passing with latest interface-ipfs-core and ipfs-api.

I left this comment regarding some possible code duplication here - ipfs/js-ipfs#1036 (review).

Also, ipfs/js-ipfs@bd70fbd fixes an issue with js-ipfs, were it never actually sent the Size of the file in the json structure, which is breaking with the latest changes in js-ipfs-api (0ea5f57#diff-ecdce0998c1946cbd6351a8c47ca9eb7R37).

[daviddias]

Woot! All merged :D This feature will come out in the next js-ipfs release. Thank you @dryajov <3

I left this comment regarding some possible code duplication here - ipfs/js-ipfs#1036 (review).

Please handle this with ipfs/js-ipfs#1041

[lidel]

Is it compatible with go-ipfs v0.4.11, or do we need to wait for v0.4.12?

[daviddias]

It should work today! The change wasn't in go-ipfs, it was just js-ipfs-api.