Skip to content
This repository was archived by the owner on Mar 10, 2020. It is now read-only.

Fixes dns test with callback #200

Merged
merged 1 commit into from
Jan 11, 2018
Merged

Fixes dns test with callback #200

merged 1 commit into from
Jan 11, 2018

Conversation

alanshaw
Copy link
Contributor

Test was previously passing because mocha didn't know it was async and no assertions were made

@ghost ghost assigned alanshaw Jan 11, 2018
@ghost ghost added the in progress label Jan 11, 2018
@hacdias
Copy link
Contributor

hacdias commented Jan 11, 2018

Thank you for fixing this! Really didn't notice 😅

@hacdias hacdias merged commit c3add1b into master Jan 11, 2018
@hacdias hacdias deleted the fix/dns-test-w-callback branch January 11, 2018 16:13
@ghost ghost removed the in progress label Jan 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants