-
Notifications
You must be signed in to change notification settings - Fork 108
Conversation
Can we provide the same level of information in js-ipfs-api? |
Good catch! I looked and no -- no we can not. go-ipfs doesn't provide more than |
we can probably shim that by making one more call? |
LGTM to merge this? |
Oh, let's not merge without tests and the tests being fully applied to both js-ipfs and js-ipfs-api. We don't want to expose a interface that isn't being used yet. We want to make sure that this document can be used as reference for implementation and for usage. |
Also, another thing is that we don't want to nail down a spec for API without getting a feeling for it during implementation process. |
Done in #16 |
Thank you @dignifiedquire. @noffle I believe you have open a PR again |
I'm in favour of getting docs merged once they are LGTM'd to make it clear they're accepted, and then work on the impl in a separate PR. We can make intentions clear at the top of the readme that this is very WIP / pre-release until then. Leaving lots of things open makes it less clear what we're LGTM on and what is still in progress. |
Somethings result from the experience of actually making the tests and adapting the API. Writing a spec and not testing it will lead to trouble |
Accepting a PR into master is not analogous to it being set in stone -- especially during early development. It gives us an agreed upon vector, with the knowledge that it can change as needed. |
Not worth further bikeshedding on -- let's just get the impl in. 😄 |
del
was intentionally omitted. It's not in js-ipfs-api, so let's not commit to it until there's a clear need / demand.block.stat
. The former is way more descriptive than the latter, so we can go with that.