This repository was archived by the owner on Jan 12, 2024. It is now read-only.
wip: example with rollup #7
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a WIP example of bundling IPFS using RollupJS.
Since js-ipfs uses CommonJS and RollupJS is an ESModule bundler the setup requires some additional configuration.
To overcome this, it was imported the following necessary plugins:
See: rollup.config.js
But it is getting some errors when performing the bundle,
(!) Circular dependencies (!) Circular dependencies polyfill-node.global.js -> polyfill-node.global.js node_modules/ipfs-bitswap/src/types/message/index.js -> node_modules/ipfs-bitswap/src/types/message/entry.js -> node_modules/ipfs-bitswap/src/types/wantlist/index.js -> node_modules/ipfs-bitswap/src/types/message/index.js node_modules/ipfs-bitswap/src/types/message/index.js -> node_modules/ipfs-bitswap/src/types/message/entry.js -> node_modules/ipfs-bitswap/src/types/wantlist/index.js -> /Users/oliveriosousa/Projects/PL/js-ipfs-examples/examples/browser-rollup/node_modules/ipfs-bitswap/src/types/message/index.js?commonjs-proxy -> node_modules/ipfs-bitswap/src/types/message/index.js
Even with circular dependencies, rollup generates a js file but when used by the app it is possible to check some mistakes, such as:
const isElectron$1 = require('is-electron');
console in the browser:
index.js:289 Uncaught ReferenceError: require is not defined
Any suggestions?
TODO
cc @hugomrdias