Skip to content
This repository was archived by the owner on Jan 12, 2024. It is now read-only.

fix: clean yarn lock #42

Closed
wants to merge 2 commits into from
Closed

fix: clean yarn lock #42

wants to merge 2 commits into from

Conversation

oliveriosousa
Copy link
Contributor

  • Cleans all the content of yarn.lock

Aims to test the real resolution of yarn with a clean install every time we run yarn install

NOTE: We cannot delete this file because it is being used to force aegir to use yarn as package manager.

@oliveriosousa
Copy link
Contributor Author

oliveriosousa commented Sep 16, 2021

Apparently, we have errors when used as a mono repo 🤔

../../node_modules/ipfs-unixfs-importer/esm/src/chunker/rabin.js:83:41-47 - Error: export 'create' (imported as 'create') was not found in 'rabin-wasm' (possible exports: __esModule, importer)

../../node_modules/ipfs-unixfs-importer/esm/src/dag-builder/dir.js:8:23-29 - Error: export 'UnixFS' (imported as 'UnixFS') was not found in 'ipfs-unixfs' (possible exports: __esModule, importer)

https://github.com/ipfs-examples/js-ipfs-examples/pull/42/checks?check_run_id=3622625347

Any suggestion?

May fix this issues too... #36 #35

@hugomrdias @achingbrain

@oliveriosousa oliveriosousa mentioned this pull request Sep 16, 2021
@achingbrain
Copy link
Contributor

This seems to be related to how yarn installs deps - it's breaking something in webpack.

Further discussion with a simple repro case: webpack/webpack#14268

@oliveriosousa oliveriosousa marked this pull request as draft September 17, 2021 15:30
@oliveriosousa
Copy link
Contributor Author

Apparently continues to fail when running the example browser-next as a monorepo.

../../node_modules/ipfs-unixfs-importer/esm/src/chunker/rabin.js
Attempted import error: 'create' is not exported from 'rabin-wasm' (imported as 'create').

My guess is some yarn resolution is being resolved incorrectly, it resolves webpack v5.53 with "enhanced-resolve": "^5.8.0" as dependency but then we have enhanced-resolved v4.5.0 installed.

Locally, custom-ipld-formats runs fine as standalone but in the CI fails with: HTTPError: Invalid request query input

@achingbrain
Copy link
Contributor

Superseded by #43

@achingbrain achingbrain deleted the fix/clean-yarn-lock branch September 29, 2021 13:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants