report() bug reproduced code. lifecycle, viewChild and angular syntax. #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdlabo
commented
Oct 12, 2023
| /** | ||
| * Error due to `@ionic/angular/standalone` not containing a lifecycle. | ||
| */ | ||
| export class LifecyclePage implements OnInit, ViewWillEnter, ViewDidEnter, ViewWillLeave, ViewDidLeave { |
There was a problem hiding this comment.
Error due to @ionic/angular/standalone not containing a lifecycle.
There was a problem hiding this comment.
This looks to be a missing set of exports from Ionic Framework. This will be addressed here: ionic-team/ionic-framework#28346!
apps/angular/ionic-angular-standalone/src/app/issue/view-child/view-child.page.ts
Show resolved
Hide resolved
apps/angular/ionic-angular-standalone/src/app/issue/not-import-one/not-import-one.page.html
Show resolved
Hide resolved
rdlabo
changed the title
This was referenced Oct 12, 2023
|
Thank you so much for the reproduction cases and testing! I appreciate you! |
|
I'm going to close this PR out now that all the feedback has been addressed 👍 the lifecycle interfaces will be available when we release v7.5.1 of Let me know if you run into any other issues or have ideas for improvement. I'll put some thought to a better reporter for manual migration steps. |
This was referenced Mar 6, 2024
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No merging is required. Reproducible code submission.