This repository was archived by the owner on Aug 5, 2022. It is now read-only.
Fix initialization with PHP 8.1 #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of PHP 8.1.0, the default mysqli error mode has been changed to exception mode[1]. That causes `$conn->select_db(DB_NAME)` to fail with an uncaught exception, preventing the database to be properly initialized. This pull request fixes this in the least intrusive way, namely by manually setting the error mode back to silent. [1] <https://wiki.php.net/rfc/mysqli_default_errmode>
cmb69
added a commit
to php/php-sdk-binary-tools
that referenced
this pull request
Dec 5, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of PHP 8.1.0, the default mysqli error mode has been changed to
exception mode[1]. That causes
$conn->select_db(DB_NAME)to failwith an uncaught exception, preventing the database to be properly
initialized.
This pull request fixes this in the least intrusive way, namely by
manually setting the error mode back to silent.
[1] https://wiki.php.net/rfc/mysqli_default_errmode
Other than this, I have not detected other issues with PHP 8.1 so far.