enable DNNL OPs(dil_gelu, dil_gelu_backward, dil_native_layer_norm, d… #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiayisunx
force-pushed
the
dnnl_op
branch
2 times, most recently
from
4e6ecf9 to
56ca4bb
Compare
|
Jiayi, I enabled BF16 lazy reorder in master, could you help to enable bf16 lazy reorder in the new dil OPs? |
|
For BF16 lazy-reorder, we will only focus on inference within this quarter. |
jiayisunx
force-pushed
the
dnnl_op
branch
2 times, most recently
from
b8c8e53 to
632ade4
Compare
|
I have enabled BF16 lazy reorder for GELU. And LayerNorm performance on BF16 is poor, so I think we could not enable this OP for now. @EikanWang |
Does that mean the performance of BF16 layernorm is not as good as fp32 layernorm? If yes, @pinzhenx , could we submit an issue to the DNNL team? |
|
Yes, and I have submitted it to DNNL team. |
…il_native_layer_norm_backward)
zhuhaozhe
pushed a commit
to zhuhaozhe/intel-extension-for-pytorch
that referenced
this pull request
Jun 24, 2020
…il_native_layer_norm_backward) (intel#41)
EikanWang
pushed a commit
that referenced
this pull request
Oct 4, 2021
remove convbn folding in JIT path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…il_native_layer_norm_backward)