Skip to content

Embedding Bag Sum Fast Support for FP32 and BFloat16 #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

JianpingChen066
Copy link
Contributor

This is to enhance the Embedding Bag Sum Fast Support for FP32 and BFloat16 with aligned parameter s in embedding_bag and embedding_bag_backward for both sparse and dense embedding tables. Also enhance some BF16 related vectorization functions.

@JianpingChen066
Copy link
Contributor Author

@hongzhen1 @EikanWang please have a review on this. Thanks

@JianpingChen066 JianpingChen066 force-pushed the EmbeddingBagSumFastPathSupport branch 2 times, most recently from 2895cf8 to 527e8e9 Compare May 25, 2020 06:25
@EikanWang
Copy link
Contributor

LGTM. @hongzhen1 r u okay with this PR?

@hongzhen1
Copy link
Contributor

LGTM. @hongzhen1 r u okay with this PR?

It's OK for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants