Slices #4
Merged
Slices #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmengler
approved these changes
May 10, 2017
| * @return int[] | ||
| */ | ||
| public function getAllProductIds(); | ||
| public function getAllProductIds($sliceId = null, $totalNumberSlices = null); |
There was a problem hiding this comment.
Note that changes in interfaces implemented by other packages are a BC break and require a major version bump. So the next release of solr-base must be 2.0.0
There was a problem hiding this comment.
Are you sure? You can still use this method as before if you skip the parameters. I'd see that as "new feature", but I don't see the BC break.
There was a problem hiding this comment.
Ah, now I see... you are right.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New functionality to index only a part of the products. You can choose how many parts ("slices") there are and which one you want to index. Additionaly, you can use the command line to clear the (swap) core or swap cores, so you can schedule your reindexing process yourself, even parallel to another indexing process.
Used by integer-net/solr-magento1#20.