Remove spaces before numbers in order to avoid search errors #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmengler
requested changes
Apr 24, 2017
src/Solr/Query/SearchString.php
Outdated
| public function getEscapedString() | ||
| { | ||
| if ($this->escapedString === null) { | ||
| $this->escapedString = $this->escape($this->getRawString()); | ||
| $this->escapedString = preg_replace('/\s([0-9])/', '$1', $this->escape($this->getRawString())); |
There was a problem hiding this comment.
Maybe change \s to \s+ to also cover repeated whitespace characters?
|
Could you check again @schmengler? |
schmengler
approved these changes
Apr 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exact matches for searches like "Omega 3" or "Jura Giga 5" returned no exact results as Solr has problems with numbers. With this PR, we change the search query to "Omega3" or "Jura Giga5", which results in direct matches.