Skip to content

Release/1.1.1 #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 11, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
### Added
- Adds frontend test coverage for global custom layout updates
- Fixes [#7](https://github.com/integer-net/magento2-global-custom-layout/issues/7) where layout handles were not merged in Product and Page Plugins' `afterFetchAvailableFiles()` method.

## 1.1.1 - 2020-05-08
### Added
- Adds module registration test (registration.php coverage)
- Adds travis config for tags/releases
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "integer-net/magento2-global-custom-layout",
"version": "1.1.0",
"version": "1.1.1",
"description": "Module for Magento 2 that allows you to add global layout update files to be selected from admin, by using '0' instead of an entity_id",
"authors": [
{
Expand Down
10 changes: 9 additions & 1 deletion tests/Integration/ModuleTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
namespace IntegerNet\GlobalCustomLayout\Test\Integration;

use Magento\Framework\App\ObjectManager;
use Magento\Framework\Component\ComponentRegistrar;
use Magento\Framework\Module\ModuleList;
use PHPUnit\Framework\TestCase;

Expand All @@ -21,6 +22,13 @@ protected function setUp()
$this->objectManager = ObjectManager::getInstance();
}

public function testModuleIsRegistered()
{
$registrar = new ComponentRegistrar();
$paths = $registrar->getPaths(ComponentRegistrar::MODULE);
$this->assertArrayHasKey(self::MODULE_NAME, $paths);
}

public function testModuleIsActive()
{
/** @var ModuleList $moduleList */
Expand All @@ -30,4 +38,4 @@ public function testModuleIsActive()
sprintf('The module %s should be enabled', self::MODULE_NAME)
);
}
}
}
3 changes: 0 additions & 3 deletions tests/Integration/phpunit.xml.dist
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,6 @@
<filter>
<whitelist addUncoveredFilesFromWhiteList="true">
<directory suffix=".php">../../../vendor/integer-net/*/src</directory>
<exclude>
<file>../../../vendor/integer-net/*/src/registration.php</file>
</exclude>
</whitelist>
</filter>
<!-- PHP INI settings and constants definition -->
Expand Down