Skip to content

Fix warning message for checkPhase #835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 5, 2020
Merged

Fix warning message for checkPhase #835

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
23a3b8e
Fix warning message for `checkPhase`
hamishmack Sep 3, 2020
e17ec32
Print the message when the test builds
hamishmack Sep 3, 2020
2db0d08
ifdLevel 3
hamishmack Sep 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions builder/comp-builder.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,8 +279,6 @@ let
runHook postBuild
'';

checkPhase = "notice: Tests are only executed by building the .run sub-derivation of this component.";

# Note: Cabal does *not* copy test executables during the `install` phase.
#
# Note 2: if a package contains multiple libs (lib + sublibs) SETUP register will generate a
Expand Down Expand Up @@ -363,6 +361,8 @@ let
runHook postInstall
'' + (lib.optionalString keepSource ''
rm -rf dist
'') + (lib.optionalString (haskellLib.isTest componentId) ''
echo The test ${package.identifier.name}.components.tests.${componentId.cname} was built. To run the test build ${package.identifier.name}.checks.${componentId.cname}.
'');

shellHook = ''
Expand Down